Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for subsystems #325

Merged
merged 2 commits into from
Jan 29, 2024
Merged

Conversation

daniel-thom
Copy link
Contributor

No description provided.

@daniel-thom daniel-thom marked this pull request as draft January 27, 2024 16:17
Copy link

codecov bot commented Jan 27, 2024

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (0ac534a) 78.83% compared to head (f27660f) 79.54%.
Report is 2 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #325      +/-   ##
==========================================
+ Coverage   78.83%   79.54%   +0.70%     
==========================================
  Files          52       53       +1     
  Lines        4135     4218      +83     
==========================================
+ Hits         3260     3355      +95     
+ Misses        875      863      -12     
Flag Coverage Δ
unittests 79.54% <97.34%> (+0.70%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/InfrastructureSystems.jl 80.00% <ø> (ø)
src/component.jl 94.67% <ø> (-0.60%) ⬇️
src/components.jl 90.00% <100.00%> (+0.15%) ⬆️
src/subsystems.jl 100.00% <100.00%> (ø)
src/supplemental_attributes.jl 93.58% <100.00%> (+0.16%) ⬆️
src/supplemental_attributes_container.jl 90.00% <100.00%> (+0.52%) ⬆️
src/iterators.jl 97.29% <96.87%> (-2.71%) ⬇️
src/system_data.jl 90.99% <90.00%> (+1.28%) ⬆️

... and 1 file with indirect coverage changes

@daniel-thom daniel-thom changed the title WIP: Add support for subsystems Add support for subsystems Jan 29, 2024
@daniel-thom daniel-thom marked this pull request as ready for review January 29, 2024 20:02
@daniel-thom daniel-thom requested a review from jd-lara January 29, 2024 20:02
Copy link
Member

@jd-lara jd-lara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes look good to me. We probably need to start with the implementation in PowerSimulationsDecomposition to find if there will be more requirements. This PR is sufficient for integration into PSY

@jd-lara jd-lara self-assigned this Jan 29, 2024
@jd-lara jd-lara merged commit 5ead8c1 into NREL-Sienna:main Jan 29, 2024
7 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants