Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

method to retrieve initial time with SingleTimeSeries #253

Open
jd-lara opened this issue Aug 28, 2021 · 2 comments
Open

method to retrieve initial time with SingleTimeSeries #253

jd-lara opened this issue Aug 28, 2021 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@jd-lara
Copy link
Member

jd-lara commented Aug 28, 2021

we need a method similar to get_forecast_initial_timestamp(sys) but for systems with only SingleTimeSeries

@jd-lara
Copy link
Member Author

jd-lara commented Aug 28, 2021

We currently support the possibility for inconsistent time series. Different lengths and initial times but same resolution across components.

This presents a problem for some simulations since we need to check the consistency of the time series across devices. We need a function that checks that all the SingleTimeSeries have the same initial time and length and also get the initial_time if they are consistent.

It might be possible to still permit inconsistent time series but requires calculating the intersection of time that is valid and that might be more cumbersome.

@jd-lara jd-lara added the enhancement New feature or request label Aug 30, 2021
@daniel-thom
Copy link
Contributor

#255 added check_time_series_consistency for SingleTimeSeries. It will return the initial timestamp and length if all time series are consistent. Otherwise, it will throw an exception. This will likely satisfy most use cases for this request. We can leave this issue open to track the addition of determining the intersection of time series with different start and end times.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants