Fixing Pumped Hydro formulation #29
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #29 +/- ##
==========================================
+ Coverage 86.14% 87.54% +1.39%
==========================================
Files 9 9
Lines 859 859
==========================================
+ Hits 740 752 +12
+ Misses 119 107 -12
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
LGTM. Wondering how we did not found this typo before. We should probably revisit the test of this constraint. Do you know where it is? |
Yes. I will add the test for this by the end of the week. |
List of changes: - Included test that validates that the PumpedHydro is operating correctly. Issue #29
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
test/test_hydro_simulations.jl
Outdated
| model = DecisionModel(template_ed, sys_ed, name="ED", optimizer=HiGHS_optimizer, | ||
| optimizer_solve_log_print=true, store_variable_names=true) |
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
| model = DecisionModel(template_ed, sys_ed, name="ED", optimizer=HiGHS_optimizer, | |
| optimizer_solve_log_print=true, store_variable_names=true) | |
| model = DecisionModel( | |
| template_ed, | |
| sys_ed, | |
| name="ED", | |
| optimizer=HiGHS_optimizer, | |
| optimizer_solve_log_print=true, | |
| store_variable_names=true, | |
| ) |
test/test_hydro_simulations.jl
Outdated
| optimizer_solve_log_print=true, store_variable_names=true) | ||
|
|
||
| @test build!(model, output_dir=output_dir) == PSI.BuildStatus.BUILT | ||
| @test solve!(model; optimizer=HiGHS_optimizer, output_dir=output_dir) == RunStatus.SUCCESSFUL |
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
| @test solve!(model; optimizer=HiGHS_optimizer, output_dir=output_dir) == RunStatus.SUCCESSFUL | |
| @test solve!(model; optimizer=HiGHS_optimizer, output_dir=output_dir) == | |
| RunStatus.SUCCESSFUL |
test/test_hydro_simulations.jl
Outdated
| @test isapprox(last_value, 0, atol=1e-5) | ||
| end | ||
|
|
||
|
|
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
|
I opened a PR on PowerSystemTestData the update to the testing system. I think once that is live the testing should pass. |
Fixes #28