Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove goto per NCO standards. #303

Open
webisu opened this issue Dec 10, 2024 · 1 comment
Open

remove goto per NCO standards. #303

webisu opened this issue Dec 10, 2024 · 1 comment
Assignees
@webisu

Comments

@webisu
Copy link
Collaborator

webisu commented Dec 10, 2024

Need to get rid of all goto's per NCO standards (Sec. IV-B-9).
@webisu webisu self-assigned this Dec 10, 2024
@webisu
Copy link
Collaborator Author

webisu commented Dec 10, 2024

Two routines are affected: decenc_openjpeg.c and Netcdf_sup.c. Eventually decenc_openjpeg.c will use the version in g2c. So it becomes an issue for NCEPLIBS;g2c. (Issue added.) NCO flagged 1617 goto's in my job. The vast majority will be in gfs and gsi. So I added an issue to g2c. The only routine that needs to be fixed is Netcdf_sup.c.

webisu added a commit that referenced this issue Dec 10, 2024
@webisu
#303 rm goto in netcdf code
4f6f2d8
@webisu webisu mentioned this issue Dec 10, 2024
Merged
AlysonStahl-NOAA added a commit that referenced this issue Dec 10, 2024
@AlysonStahl-NOAA
Merge pull request #304 from NOAA-EMC/goto
a9a04f0 
#303 rm goto in netcdf code
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@webisu webisu

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@webisu