Add support for global aerosol DA in JCB #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CoryMartin-NOAA
requested review from
danholdaway,
ypwang19,
andytangborn and
DavidNew-NOAA
danholdaway
approved these changes
Oct 22, 2024
| mass_fraction_of_dust005_in_air, mass_fraction_of_sea_salt001_in_air, | ||
| mass_fraction_of_sea_salt002_in_air, mass_fraction_of_sea_salt003_in_air, | ||
| mass_fraction_of_sea_salt004_in_air] | ||
| datapath: ./bkg |
There was a problem hiding this comment.
Since the idea (in general) is to have absolute flexibility on the JCB side I wonder if this (there are other examples elsewhere too) could be replaced with a variable? Say {{aero_bkg_datapath}} for example, then have aero_bkg_datapath: ./bkg on your GDASapp side? Then there is no evidence of global workflow assumptions about path structure in JCB. Someone could pull this YAML into another environment without having to modify the YAML.
There was a problem hiding this comment.
yep, I can do that.
andytangborn
approved these changes
Oct 22, 2024
DavidNew-NOAA
approved these changes
Oct 22, 2024
danholdaway
approved these changes
Oct 22, 2024
CoryMartin-NOAA
added a commit
to NOAA-EMC/GDASApp
that referenced
this pull request
Nov 6, 2024
What the title says. Depends on: NOAA-EMC/jcb-gdas#33 NOAA-EMC/jcb-algorithms#5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add in templates so that global aerosol DA can use JCB to generate YAML configuration for the variational application + B matrix supporting executables.