Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update observation yamls for atmosphere var and local ensemble DA #21

Merged

Conversation

RussTreadon-NOAA
Copy link
Contributor

This PR updates observation templates use by the variational and local ensemble atmosphere applications. The following changes are included in this PR

  • updating radiance bias correction keywords
  • renaming templates to match bufr2ioda converter names
  • adding observation templates for lgetkf

Resolves #20

@RussTreadon-NOAA RussTreadon-NOAA self-assigned this Aug 8, 2024
@RussTreadon-NOAA
Copy link
Contributor Author

@emilyhcliu , the changes in this PR are ready for review. Who among our UFO validation staff do you recommend as reviewers?

@CoryMartin-NOAA , I think the automated testing failed because it is looking for feature/bufr2ioda in the NOAA-EMC/jcb-gdas repo. This branch does not exist in NOAA-EMC/jcb-gdas. Branch feature/bufr2ioda is in my jcb-gdas fork. Can/should we generalize automated testing to clone the PR branch from the appropriate repo?

@CoryMartin-NOAA
Copy link
Contributor

@RussTreadon-NOAA I'm not sure if it's easy to use the forks for the automated testing. Dan set this up so I'm not sure how it works, but we can look into it

@RussTreadon-NOAA
Copy link
Contributor Author

@RussTreadon-NOAA I'm not sure if it's easy to use the forks for the automated testing. Dan set this up so I'm not sure how it works, but we can look into it

Thank you @CoryMartin-NOAA . If we want to explore this possibility, it can be done via a different issue & PR

@CoryMartin-NOAA
Copy link
Contributor

if the test failure causes a problem with merging we can always force-merge, we have the power (but we must use that power judiciously)

@CoryMartin-NOAA CoryMartin-NOAA merged commit a132852 into NOAA-EMC:develop Aug 8, 2024
1 check failed
@RussTreadon-NOAA RussTreadon-NOAA deleted the feature/bufr2ioda branch August 8, 2024 23:05
@RussTreadon-NOAA
Copy link
Contributor Author

Thank you @ADCollard and @CoryMartin-NOAA

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update observation templates
3 participants