Companion PR to NOAA-EMC/jcb/pull/7 #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* develop: Update atmosphere-lgetkf satwnd yamls (#13)
danholdaway
requested review from
CoryMartin-NOAA,
guillaumevernieres,
RussTreadon-NOAA and
DavidNew-NOAA
CoryMartin-NOAA
approved these changes
May 29, 2024
DavidNew-NOAA
approved these changes
May 29, 2024
* develop: Yaml updates for use with updated GDASApp submodules (#8)
model/atmosphere/atmosphere_background_error_hybrid_gsibec_bump.yaml.j2
Outdated
Show resolved
Hide resolved
danholdaway
commented
Jun 10, 2024
model/atmosphere/atmosphere_background_error_hybrid_gsibec_bump.yaml.j2
Outdated
Show resolved
Hide resolved
|
@danholdaway: Can we merge this PR into |
|
@RussTreadon-NOAA I'm not sure about merging because it will confuse what is being tested in g-w. If ultimately we need jcb and gdasapp on develop in order to test and merge NOAA-EMC/global-workflow#2665 then merging this will then mean testing these changes in that PR. I would prefer to merge that PR (and associated jcb/gdas PRs) first. Unless I'm missing something if we merge these now then we may have to end up testing them with NOAA-EMC/global-workflow#2665. |
* feature/no_sub_mods: add comment action debugging action debugging action debugging action debugging action debugging action debugging action debugging action debugging action debugging action debugging Make sure to init clients in GH test pyyaml Adjust testing for new path checker file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Companion PR: NOAA-EMC/jcb/pull/7
atmosphere_<class>.yaml.j2{{atmosphere_<key>}}