Update scripts to use the GW-RT global namelist #3017
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR changes the ways the input.nml file is created. Instead of creating a namelist, the variables that are set locally will now use the UFS
global_control.nml.IN
template and the atparse function to generate the namelist.This should allow the GW branch to more easily test changes in the UFS regression test framework. It will also allow GW to more easily introduce UFS changes into GW.
The functionality in
parsing_namelists_FV3.sh
is mostly unchanged. Since variables are still saved aslocal
, the parsing of the template will occur in this script. Sections in the namelist that were previously not generated (stoch physics options for example) will be set and parsed since the regression test template has these placeholders active. As options are turned off and on, ! will be used in the namelist to comment out sections that are not used.Previous PR #2733 was closed since my old branch was stale and a new branch was created.
Unresolved issues and input needed from GW group before final code review
First of all,
global_control.nml.IN
has been added in the root directory of global_workflow. This will not be in the final commit. This is a place holder until the pathing to the UFS template is finalized. A variable with the final path will also be needed to replace the hardcoded path inparsing_namelists_FV3.sh
.There are some variables that were not set in the original scripts that have been added. These were set to the UFS defaults.
The tests I've conducted were to generate the namelists but more tests should be done to make sure that outputs have not changed.
Resolves #2731
Resolves ufs-community/ufs-weather-model#1664
Outstanding dependencies:
ufs-community/ufs-weather-model#2425
Type of change
Change characteristics
How has this been tested?
Tested namelist generation with C48ATM and C48S2S configurations. Further testing will need to be done to ensure intended funcitonality.
Checklist