Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor sfcsub.F for sfccycle/gcycle in the UFS #892

Open
XuLi-NOAA opened this issue Dec 1, 2024 · 0 comments
Open

Refactor sfcsub.F for sfccycle/gcycle in the UFS #892

XuLi-NOAA opened this issue Dec 1, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@XuLi-NOAA
Copy link
Contributor

XuLi-NOAA commented Dec 1, 2024

Description

The legacy code has been developed across multiple generations, lacking consistency, adequate documentation, and efficient coding practices, resulting in some redundancy. The aim of this task is to enhance all of these aspects.refactor sfcsub.F for sfccycle/gcycle in the UFS

Solution

  1. Prepare all the fix files, including climaology, beforehand at the required native model resolutions.
  2. Remove the horizontal interpolations in gcycle
  3. Simplify the code

Alternatives

It has been discussed to update the surface variables through coupled facility in UFS. But it will be done when things become ready in the future.

Testing:

  1. Have you tested the code changes? On what platforms?
  2. Have you run regression test in ufs-weather-model or ufs-s2s-model with code changes?
  • Will the baseline results change?
  • If yes, please give brief explanation of your code updates on the regression test.

Dependent PRs:

Directly reference any issues or PRs in this or other repositories that this is related to, and describe how they are related. Example:

  • required to support noaa-emc/GFDL_atmos_cubed_sphere/issues/<issue_number>
  • ncar/ccpp-physics/pull/<pr_number>
  • associated ufs-weather-model/pull/<pr_number>
@XuLi-NOAA XuLi-NOAA added the enhancement New feature or request label Dec 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant