Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modified scripts/plot_proftrace.py to close figures after saving to file #151

Merged
merged 3 commits into from
Dec 5, 2024

Conversation

BrettHoover-NOAA
Copy link
Collaborator

Minor changes to scripts/plot_proftrace.py:

  1. Close each figure after it has been created and saved to file. In the absence of these plt.close() commands matplotlib.pyplot will raise a warning if more than 20 figures are opened without being closed. We don't need to keep these open after they have been written to file, so it's fine to include these close commands.
  2. Replace checks on input types from if type(x) != list to the now standardized if not isinstance(x, list) format, for pycodestyle

Copy link
Collaborator

@kevindougherty-noaa kevindougherty-noaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@BrettHoover-NOAA BrettHoover-NOAA merged commit 0489afe into develop Dec 5, 2024
2 checks passed
@BrettHoover-NOAA BrettHoover-NOAA deleted the feature/proftrace branch December 5, 2024 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants