Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove pfunit and ENABLE_TESTS option, tests will always be enabled #15

Open
edwardhartnett opened this issue Sep 30, 2020 · 2 comments

Comments

@edwardhartnett
Copy link
Contributor

edwardhartnett commented Sep 30, 2020

I build like this:

cmake -DCMAKE_PREFIX_PATH=/home/ed/NCEPLIBS/NCEPLIBS-landsfcutil ..
make VERBOSE=1

and it works. But when I try to run tests:

(base) ed@mikado:~/NCEPLIBS-landsfcutil/b$ make tests
make: *** No rule to make target 'tests'.  Stop.
(base) ed@mikado:~/NCEPLIBS-landsfcutil/b$ make test
make: *** No rule to make target 'test'.  Stop.
@aerorahul
Copy link
Contributor

One needs to pass the -DENABLE_TESTS=ON flag to CMake.
Testing requires pFUNIT, so you will need to have that available on your system.

@edwardhartnett
Copy link
Contributor Author

Yes, I finally figured that out. ;-)

However, we have decided to do away with pfunit for exactly this sort of reason, so then we can also eliminate the ENABLE_TESTS option, and always enable tests, just like most other projects do.

@edwardhartnett edwardhartnett changed the title make test doesn't work? remove pfunit and ENABLE_TESTS option, tests will always be enabled Sep 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants