Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to latest Consortium/main #55

Closed
DeniseWorthen opened this issue Jan 6, 2023 · 0 comments · Fixed by #56 or ufs-community/ufs-weather-model#1562
Closed

Update to latest Consortium/main #55

DeniseWorthen opened this issue Jan 6, 2023 · 0 comments · Fixed by #56 or ufs-community/ufs-weather-model#1562

Comments

@DeniseWorthen
Copy link
Collaborator

DeniseWorthen commented Jan 6, 2023

Updates to include the following PRs which are not expected to change baselines:

CICE-Consortium#778. This PR simplifies the initialization of the dynamics and removes unnecessary code or allocations.

CICE-Consortium#790. This PR renames cicedynB to cicedyn (with link) and fixes some metadata in netcdf files for C-grid.

The following PRs change answers as noted:

CICE-Consortium#802. This PR changes calculation of stress12T to give non-zero values for the C-grid. It will change answers only for the C-grid test.

CICE-Consortium#799. This PR contains a bug fix for the accumulation of salt and freshwater fluxes when ktherm=2 (ie, mushy thermo) as well as a new feature to use the actual bulk-salinity of sea ice to calculate the fluxes. Without the saltflux feature turned on, sea ice is assumed to have a constant bulk salinity of 4psu. The new feature allows the actual sea ice salinity prognostically determined by the mushy therm scheme to determine the salt flux. The bug fix changes all UFS baselines which use ktherm=2.

The relevant section of code in icepack/columnphysics/icepack_therm_itd.F90 which contained the bug is:

      if (update_ocn_f) then
         if (ktherm <= 1) then
            dfresh = -rhoi*vi0new/dt
            dfsalt = ice_ref_salinity*p001*dfresh
            fresh  = fresh + dfresh
            fsalt  = fsalt + dfsalt
         ! elseif (ktherm == 2) the fluxes are added elsewhere
         endif

See Icepack issue CICE-Consortium/Icepack#390

Baseline changes for the NG-GODAS tests are due to code refactoring associated with the saltflux feature, since the debug test case reproduces.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant