Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop aFONLL support, support FFNS #122

Open
alecandido opened this issue Oct 6, 2023 · 2 comments
Open

Drop aFONLL support, support FFNS #122

alecandido opened this issue Oct 6, 2023 · 2 comments
Labels
enhancement New feature or request good first issue Good for newcomers physics Physics feature

Comments

@alecandido
Copy link
Member

As soon as everyone migrated to nFONLL we should remove all the branching with aFONLL, and just support a single FONLL implementation.

E.g. the following should only keep the if branch

pineko/src/pineko/evolve.py

Lines 133 to 139 in 3f3c887

if check.is_num_fonll(tcard["FNS"]):
nf = tcard["NfFF"]
operators_card["mugrid"] = [(float(np.sqrt(q2)), int(nf)) for q2 in q2_grid]
else:
operators_card["mugrid"] = [
(float(np.sqrt(q2)), nf_default(q2, atlas)) for q2 in q2_grid
]

and this should be removed

pineko/src/pineko/check.py

Lines 161 to 163 in 3f3c887

def is_num_fonll(FNS):
"""Check if the FNS is a num_fonll FNS."""
return FNS in ["FONLL-FFNS", "FONLL-FFN0"]

@alecandido
Copy link
Member Author

Also considered that nf_default is not really part of the stable API (no way anyone knew it, I wrote it and decided myself :P).
So, it might be dropped or become hidden (_ prepended) at some point.

@felixhekhorn felixhekhorn added the enhancement New feature or request label Oct 9, 2023
@giacomomagni
Copy link
Contributor

giacomomagni commented Feb 15, 2024

Some of these checks are actually needed also to allow for ZM-VFNS.
Right now, What is not supported is plain FFNS.

@giacomomagni giacomomagni added the physics Physics feature label Mar 8, 2024
@scarlehoff scarlehoff changed the title Drop aFONLL support Drop aFONLL support, support FFNS Sep 18, 2024
@scarlehoff scarlehoff added the good first issue Good for newcomers label Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers physics Physics feature
Projects
None yet
Development

No branches or pull requests

4 participants