Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Import external "void" from yadmark #17

Open
alecandido opened this issue Jan 20, 2022 · 0 comments
Open

Import external "void" from yadmark #17

alecandido opened this issue Jan 20, 2022 · 0 comments
Labels
runners Tools for writing benchmarks' runners

Comments

@alecandido
Copy link
Member

At the moment, "void" external (i.e. just run myself, leave external empty) is only implemented inside yadmark:

https://github.com/N3PDF/yadism/blob/593a012dc7f4666c2c993dbdd37a6a2d55db0455/benchmarks/yadmark/benchmark/runner.py#L100-L112

This is rather useful (especially thinking about ekobox and yadbox), so I propose:

  • move that code from yadmark to banana
  • replace "void" (meaningful, but a bit random) with just None (it seems natural to me that, if the external is empty, then no external should be used)
@alecandido alecandido added the runners Tools for writing benchmarks' runners label Jan 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
runners Tools for writing benchmarks' runners
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@alecandido