Skip to content
This repository has been archived by the owner on Aug 7, 2024. It is now read-only.

fix(flake8): Fix flake8 errors in app.py. #9

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

fix(flake8): Fix flake8 errors in app.py. #9

wants to merge 7 commits into from

Conversation

James-Makela
Copy link
Collaborator

@James-Makela James-Makela commented May 29, 2024 •
edited by 20095325
Loading

Fixes Required:

  • app.py
  • extract_text.py
  • pre_process.py
  • remotellama.py

@James-Makela James-Makela linked an issue May 29, 2024 that may be closed by this pull request
Build workflow is failing due to Flake8 Linting Errors #8
Open
@James-Makela James-Makela marked this pull request as ready for review May 29, 2024 02:59
20095325
20095325 reviewed Jun 8, 2024
View reviewed changes
app/app.py
Comment on lines -209 to +210
if video_data['processed'] == False and video_data['processing'] == False:
if video_data['processed'] is False and video_data['processing'] is False:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these do not work if you use "is" we had to use "=="

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noted. Although I am failing to understand why it is not working. Is it in more cases than just here? Going through debugging at this line, the if block is entered for an unprocessed, and not being processed video, and not entered if the video is processing or processed.

20095325
20095325 suggested changes Jun 8, 2024
View reviewed changes
Copy link
Collaborator

@20095325 20095325 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please just use "==" instead of "is"

20095325
20095325 suggested changes Jun 13, 2024
View reviewed changes
Copy link
Collaborator

@20095325 20095325 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please can you resolve all conflicts, then I am happy to merge this

@James-Makela
Copy link
Collaborator Author

Conflicts resolved. Do you want me to revert the is statements back to == before proceeding? And there are new flake8 errors to resolve now before linting will pass. I can fix those if that is helpful. But happy to leave as it is if its going to be more of a pain at this time.

@20095325
Copy link
Collaborator

@James-Makela does the "is" statement work for you? if it does then we can leave it.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@20095325 20095325 20095325 requested changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Build workflow is failing due to Flake8 Linting Errors
2 participants
@James-Makela @20095325