Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

faq added #73

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

faq added #73

wants to merge 3 commits into from

Conversation

prabhat04011998
Copy link

@prabhat04011998 prabhat04011998 commented Dec 19, 2020 •
edited
Loading

Closes #33
FAQ section added

@vercel
Copy link

vercel bot commented Dec 19, 2020 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/s-ayush2903/nwoc-website-alpha-version/cqq24ewwn
✅ Preview: https://nwoc-website-alpha-version-git-fork-prabhat04011998-master.s-ayush2903.vercel.app

@prabhat04011998
Copy link
Author

@s-ayush2903 please check in the faq tab , you'll see the page.

@s-ayush2903
Copy link
Member

@prabhat04011998 Can you animate the answer flow, it would look nicer as currently it looks quite abrupt because a click and answer just appears and therefore does not match with the entire theme of the website. It can be better if you can add a dropdown flow similar to the one which appears when on codeforces while reading an editorial of a contest when you click the Tutorial or the Solution section.

@s-ayush2903
Copy link
Member

Also change the issue description to Closes #issueNum, doing so will close the issue on successful merge of this PR only if you write in description the given one in the exact format told. Also please change the Page title and heading title to FAQs not FAQ.

@prabhat04011998
Copy link
Author

prabhat04011998 commented Dec 31, 2020 •
edited
Loading

@s-ayush2903 deployment is failed there is some problem with billing method, i have updated the design and it's pretty well.If any feedback let me know.

@NJACKWinterOfCode NJACKWinterOfCode deleted a comment from vercel bot Dec 31, 2020
@s-ayush2903
Copy link
Member

@prabhat04011998 push a commit to trigger the deployment

s-ayush2903
s-ayush2903 requested changes Dec 31, 2020
View reviewed changes
Copy link
Member

@s-ayush2903 s-ayush2903 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • The FAQs option from navDrawer and from the toolbar is lost as soon as I navigate back from FAQs to some other section(say projects), which does not impart a good UX
  • The FAQs page is incoherent with the rest of the website

@s-ayush2903
Copy link
Member

@prabhat04011998 Do you plan to work on this further?

@prabhat04011998
Copy link
Author

Ohh yes I'll complete the pr ,will not drop it in middle. @s-ayush2903

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@s-ayush2903 s-ayush2903 s-ayush2903 requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

FAQs
2 participants
@prabhat04011998 @s-ayush2903