Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge last changes from local repo into NIRAL repo #10

Open
bpaniagua opened this issue Aug 3, 2018 · 3 comments
Open

Merge last changes from local repo into NIRAL repo #10

bpaniagua opened this issue Aug 3, 2018 · 3 comments

Comments

@bpaniagua
Copy link

Please, Mahmoud,

Can you merge your last changes into this repo? We are about to fix the windows compilation issues.
https://github.com/MahmoudMostapha/GROUPS

Thanks,
Bea

@phcerdan
Copy link
Contributor

phcerdan commented Aug 14, 2018

We have diverged from the upstream repo: https://github.com/ilwoolyu/GROUPS.

I think there are no changes in MahmoudMostapha fork of ours.

We should rebase our fork on top of upstream. See #9

@jcfr
Copy link
Contributor

jcfr commented Aug 15, 2018

@juanprietob Would be great to coordinate with @ilwoolyu so that efforts aare put toward one project. See NIRALUser/MeshLib#3 (comment) for possible approaches

@jcfr
Copy link
Contributor

jcfr commented Nov 26, 2018

The change to be be backported are the following: https://github.com/ilwoolyu/GROUPS/compare/cfaf88489d5bb2277fd823cd410e18b1e8839075...master

optimized triangle query - updated MeshLib required
added: an option to specify fixed subjects
update: fixed subject variable name convention
update: property z-score normalization
update: no-write coeff for fixed subjects 

@jcfr jcfr mentioned this issue Nov 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants