Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Popup changes re-run watch script #171

Closed
thePeras opened this issue Jul 23, 2024 · 2 comments · Fixed by #201
Closed

Popup changes re-run watch script #171

thePeras opened this issue Jul 23, 2024 · 2 comments · Fixed by #201
Assignees
@JaimeFRF
Labels
bug
Milestone
Version 1.1

Comments

@thePeras
Copy link
Member

Currently, saved changes on popup are not reloading the extension.
@thePeras thePeras added the bug label Jul 23, 2024
@thePeras
Copy link
Member Author

Check #165 for more context

@JaimeFRF JaimeFRF self-assigned this Oct 31, 2024
@thePeras
Copy link
Member Author

thePeras commented Nov 1, 2024 •
edited
Loading

@JaimeFRF Last time I work on this I notice the problem is the CopyPlugin is not being executing on changes, just at the start when you execute the watch script. You can check this by deleting the copied files after start yarn watch and change something. No file will be copied again.
I think I don't fix that, I am not sure

@JaimeFRF JaimeFRF linked a pull request Nov 5, 2024 that will close this issue
changed klaw file filter #201
Merged
@JaimeFRF JaimeFRF mentioned this issue Nov 6, 2024
Merged
@toni-santos toni-santos added this to the Version 1.1 milestone Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JaimeFRF JaimeFRF

Labels
bug
Projects
None yet
Milestone
Version 1.1
Development

Successfully merging a pull request may close this issue.

changed klaw file filter NIAEFEUP/nitsig
3 participants
@thePeras @toni-santos @JaimeFRF