Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xmllint opt-out flag #606

Open
mwaxmonsky opened this issue Oct 25, 2024 · 0 comments
Open

xmllint opt-out flag #606

mwaxmonsky opened this issue Oct 25, 2024 · 0 comments
Assignees

Comments

@mwaxmonsky
Copy link
Collaborator

Description

As discovered in #601, xmllint is always being checked and run if found. This creates an implicit dependency on xmllint that shouldn't be required for all runs of capgen.

Solution

Add an explicit flag to disable xmllint-ing and associated handling for checking if xmllint is available in the environment if enabled. This way if the flag is not turned on and xmllint is not found in the environment, an error can be generated instead of silently failing and just printing to stdout.

Alternatives (optional)

Discussed an opt-in flag but most uses cases are going to require linting.

Related to (optional)

#601

@mwaxmonsky mwaxmonsky self-assigned this Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

When branches are created from issues, their pull requests are automatically linked.

1 participant