Include rof in run.py #132
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mnlevy1981
requested changes
Sep 10, 2024
| @@ -47,6 +48,7 @@ | |||
| @click.option("--land", "-lnd", is_flag=True, help="Run land component diagnostics") | |||
| @click.option("--seaice", "-ice", is_flag=True, help="Run sea ice component diagnostics") | |||
| @click.option("--landice", "-glc", is_flag=True, help="Run land ice component diagnostics") | |||
| @click.option("--river_runoff", "-rof", is_flag=True, help="Run river runoff component diagnostics") | |||
There was a problem hiding this comment.
For time-series generation, we use a - in the command line option rather than an _ (--time-series, not --time_series); to stick with at, I think we want --river-runoff here. Changing this means we'll also need to change the README file.
|
Oops, I had already added these changes directly to Naoki's PR... my bad! Leaving this here for the time being while working with CISL on environment issues related to rof/geopandas, but this doesn't need to be reviewed right now. |
|
Ok, I think we figured out the issue Bret was having. Closing this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This includes
rofin the components that are looped through inrun.py. This is important for including Naoki'srofnotebooks.pre-commitcheck)?Note that there should also be a rof timeseries section, which probably should be brought in alongside Naoki's PR.