Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simultaneous timeseries generation for multiple history files types within a model component #148

Open
jshaw35 opened this issue Oct 17, 2024 · 4 comments

Comments

@jshaw35
Copy link

jshaw35 commented Oct 17, 2024

Is your feature request related to a problem? Please describe.
I am currently using CUPiD for timeseries generation. The flexibility and ease-of-use is awesome, but I can only process a single history file type from a model component at a time (e.g. not both monthly and daily CAM outputs).

Describe the solution you'd like
I have made some minor changes to cupid/run.py that allow users to specify multiple history file strings and data variable lists for each model component (in a config.yml file). I wasn't sure if these changes were compatible with other CUPiD functionality that I haven't used and wanted to check.

Describe alternatives you've considered
It is less convenient but still totally functional to create a config.yml file for each history file type to post-process (e.g. h0, h1, etc).

Additional context
N/A

@AgentOxygen
Copy link

The GenTS implementation I developed for #143 processes all of the history file types by default, ignoring the history file string parameter. I was looking into adding a parameter to filter out undesired history files, but haven't gotten that far yet. The current version might be practical enough for your use case though

@jshaw35
Copy link
Author

jshaw35 commented Oct 17, 2024

Hi Cameron, thanks for the heads up on the GenTS implementation! Being able to specify history files and variables is definitely helpful for time and storage use in my applications. I will check out your implementation. I am also interested in what CUPiD users/developers think about the proposed functionality and if it would be relevant to the broader user base.

@mnlevy1981
Copy link
Collaborator

@jshaw35 The API for generating time series is a work in progress, but @TeaganKing and I are hoping to come up with a redesign that would provide more control over the time period covered by each file as well as support for variables in multiple streams. We'll start that work next week, but I don't have a good estimate for when it will be ready.

@jshaw35
Copy link
Author

jshaw35 commented Oct 30, 2024

@mnlevy1981 thanks for the update! I have added handling of multiple streams and some simplistic output chunking for my own use. My changes are on this fork: https://github.com/jshaw35/CUPiD feel free to use them if it is helpful!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants