-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Require a validate output report be submitted in order to generate a SIP #11
Comments
Hi @jordanpadams . SBN may have a concern with this given some of the things that have (or may) be reported as errors. For instance many of our collections include directory names of "data" or "document" which the validate tool calls out as an error. |
@tbarnes4 understood. we will need to work out some of these details, however, please feel free to propose issues for updates to validate for these false errors. some issues have been identified in the past with validate where there was a misinterpretation of the standards and/or the language in the standards have changed over time. additionally, i believe the issue you are seeing above actually throws a warning now as this was raised by other folks as well., |
@jordanpadams I will try and keep this in mind, and remind other invested SBN folks. The issue I mentioned is still being reported as an error in: gov.nasa.pds:validate I believe this is the current release based on the support pages. |
@tbarnes4 copy. that fix has only happened in the last couple months, so it is available in our unstable build: https://github.com/NASA-PDS/validate/releases/tag/v1.25.0-SNAPSHOT . Feel free to test this out or you can wait for a tag (coming in a couple months) |
Require a JSON report output from Validate be submitted to ensure the bundle is valid prior to generate. Report checks should include:
Applicable requirements
Primary - 🦄 #53
Related to #6
The text was updated successfully, but these errors were encountered: