Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require a validate output report be submitted in order to generate a SIP #11

Open
jordanpadams opened this issue Jan 24, 2020 · 4 comments
Labels

Comments

@jordanpadams
Copy link
Member

jordanpadams commented Jan 24, 2020

Require a JSON report output from Validate be submitted to ensure the bundle is valid prior to generate. Report checks should include:

  • No errors reported
  • Verify PDS4 bundle validation and content validation were performed

Applicable requirements
Primary - 🦄 #53

Related to #6

@tbarnes4
Copy link

Hi @jordanpadams . SBN may have a concern with this given some of the things that have (or may) be reported as errors. For instance many of our collections include directory names of "data" or "document" which the validate tool calls out as an error.

@jordanpadams
Copy link
Member Author

@tbarnes4 understood. we will need to work out some of these details, however, please feel free to propose issues for updates to validate for these false errors. some issues have been identified in the past with validate where there was a misinterpretation of the standards and/or the language in the standards have changed over time. additionally, i believe the issue you are seeing above actually throws a warning now as this was raised by other folks as well.,

@tbarnes4
Copy link

tbarnes4 commented Mar 4, 2021

@jordanpadams I will try and keep this in mind, and remind other invested SBN folks.

The issue I mentioned is still being reported as an error in:

gov.nasa.pds:validate
Version 1.24.0
Release Date: 2020-09-08 22:33:13

I believe this is the current release based on the support pages.

@jordanpadams
Copy link
Member Author

@tbarnes4 copy. that fix has only happened in the last couple months, so it is available in our unstable build: https://github.com/NASA-PDS/validate/releases/tag/v1.25.0-SNAPSHOT . Feel free to test this out or you can wait for a tag (coming in a couple months)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: ToDo
Development

No branches or pull requests

2 participants