-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Necessary values are propagated to veda-routes repo for CloudFront distribution origin management #402
Comments
@botanical could you define what you mean by 'propagate'? And what values from those services are being propagated? URLs? |
@ciaransweet, definitely! I added some links in the issue description, hopefully that's helpful. In our |
@botanical Gotcha. So in terms of the specific values of the origins, do you mean the domains? à la: https://docs.aws.amazon.com/cdk/api/v2/python/aws_cdk.aws_cloudfront_origins/HttpOrigin.html which will return a https://docs.aws.amazon.com/cdk/api/v2/python/aws_cdk.aws_cloudfront/OriginBindConfig.html#aws_cdk.aws_cloudfront.OriginBindConfig which will have a: https://docs.aws.amazon.com/cdk/api/v2/python/aws_cdk.aws_cloudfront/CfnDistribution.html#aws_cdk.aws_cloudfront.CfnDistribution.OriginProperty which contains the final domain? |
Yeah, the origin domain names! Sorry if my verbiage was confusing, @ciaransweet. I think we could use This is an example of how we do it currently in veda-backend. self.distribution.add_behavior(
path_pattern="/api/stac*",
origin=origins.HttpOrigin(
f"{stac_api_id}.execute-api.{region}.amazonaws.com",
origin_id="stac-api",
),
cache_policy=cf.CachePolicy.CACHING_DISABLED,
allowed_methods=cf.AllowedMethods.ALLOW_ALL,
origin_request_policy=cf.OriginRequestPolicy.ALL_VIEWER_EXCEPT_HOST_HEADER,
) The API Gateway values should be included in the cloudformation output, so we can write something to retrieve the API GW values. For example, here are the constructs for the APIs that call As for the s3 bucket for the s3 origin, I will get back to you on how that can be retrieved 🤔 For example, using the
in the cloudformation output but don't see where we actually output that in |
Ah, I think I got confused. So right now those We know what the services are we want to have in the distribution, not sure we have a usecase where it has to be able to add services dynamically yet? If so, my idea on what we're doing is:
I wondered if we wanted to expose what type of origin they were but again, right now it's not dynamic so we can effectively copy + paste the |
Context
Propagate the necessary values for CloudFront distribution origin management
Acceptance Criteria
The text was updated successfully, but these errors were encountered: