From f03e60f0fd2838e2da3dd599e7f5d5ebbd5ba1c2 Mon Sep 17 00:00:00 2001 From: William Robertson Date: Tue, 19 Nov 2024 17:33:02 -0500 Subject: [PATCH] [zksend SDK] fix getSentTransactions not respecting the passed in SuiClient URL (#20334) ## Description Context: https://mysten-labs.slack.com/archives/C0701K5UHCP/p1732048923401389 We aren't passing through the Sui client instance to `loadAssets`, so it's defaulting to the public fullnode URL in Stashed which has heavier rate limits as opposed to our internal RPC. image ## Test plan How did you test the new or updated feature? --- ## Release notes Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required. For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates. - [ ] Protocol: - [ ] Nodes (Validators and Full nodes): - [ ] Indexer: - [ ] JSON-RPC: - [ ] GraphQL: - [ ] CLI: - [ ] Rust SDK: - [ ] REST API: --- .changeset/shiny-cups-sniff.md | 5 +++++ sdk/zksend/src/links/get-sent-transactions.ts | 1 + 2 files changed, 6 insertions(+) create mode 100644 .changeset/shiny-cups-sniff.md diff --git a/.changeset/shiny-cups-sniff.md b/.changeset/shiny-cups-sniff.md new file mode 100644 index 0000000000000..3c367a607be8b --- /dev/null +++ b/.changeset/shiny-cups-sniff.md @@ -0,0 +1,5 @@ +--- +'@mysten/zksend': patch +--- + +Fix getSentTransactionsWithLinks defaulting to the public fullnode URL diff --git a/sdk/zksend/src/links/get-sent-transactions.ts b/sdk/zksend/src/links/get-sent-transactions.ts index ddc33b4c79531..594fe1a5af792 100644 --- a/sdk/zksend/src/links/get-sent-transactions.ts +++ b/sdk/zksend/src/links/get-sent-transactions.ts @@ -87,6 +87,7 @@ export async function getSentTransactionsWithLinks({ address, contract, isContractLink: true, + client, ...linkOptions, });