Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for targeted sequencing #28

Open
iqbal-lab opened this issue Oct 17, 2018 · 8 comments · May be fixed by #163
Open

Add support for targeted sequencing #28

iqbal-lab opened this issue Oct 17, 2018 · 8 comments · May be fixed by #163
Labels
enhancement New feature or request

Comments

@iqbal-lab
Copy link
Collaborator

This has been sitting around as a possibility for some time; we should just do it.
I propose

  1. Chuck out species id
  2. Update genome size to be lengths of genes in our targets (allow user specification)
  3. Otherwise should run as normal
@iqbal-lab iqbal-lab added the enhancement New feature or request label Oct 17, 2018
@mbhall88
Copy link
Member

Do we actually use the genome size? I can't seem to find any reference to it in the code.

@iqbal-lab
Copy link
Collaborator Author

Only to estimate depth somewhere

@iqbal-lab
Copy link
Collaborator Author

This issue should be closed, Mykrobe already supports amplicon sequencing . There's a force option to skip species id, and it works on amplicons afaik

@iqbal-lab
Copy link
Collaborator Author

I'll update properly on Tue

@mbhall88
Copy link
Member

Okay, awesome.

@martinghunt do you know where in the code genome size impacts the depth esimation? I can't seem to see it anywhere...

@mbhall88
Copy link
Member

Okay, have realised targetted/amplicon sequencing isn't really supported.

I have been running mykrobe on some amplicon data where expected median depth should be in the thousands, but am getting estimated median depth of significantly less than that (single digits or low hundreds).

I'm trying to parse the current method for estimating depth, but it is pretty convoluted...

I'll keep digging away to see if I can find the best place to handle this.

My thoughts are to have an option like --amplicon which optionally takes a fasta reference. If no fasta reference is passed, we use the size of the genes in mykrobe's panel, otherwise we use the sum of sequence lengths in the provided fasta.

Thoughts?

@iqbal-lab
Copy link
Collaborator Author

Sorry @mbhall88 was busy today, will think and reply tomorrow

@mbhall88 mbhall88 changed the title Add support for targetted sequencing Add support for targeted sequencing Oct 3, 2022
@mbhall88
Copy link
Member

mbhall88 commented Oct 3, 2022

I've been playing with this locally. It's tricky. It's also extra tricky because the amplicon data I'm working with isn't amplifying entire genes. So lots of the variants have depth of like 0 or 1 and the rest have like 100,000. This ends up skewing the median depth calculation....

Any other thoughts on how to better estimate the depth? I mean, a plot of kmer_counts and cutting out the counts of the first peak and then taking the median of the rest sounds reasonable, but not sure how to do this.

@mbhall88 mbhall88 linked a pull request Oct 7, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants