Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provide schema, refactor for version 2 #33

Open
tacman opened this issue Jun 17, 2024 · 0 comments
Open

provide schema, refactor for version 2 #33

tacman opened this issue Jun 17, 2024 · 0 comments

Comments

@tacman
Copy link

tacman commented Jun 17, 2024

{
  "Title": "Ferdinandsbrücke Project, Vienna, Austria (Elevation, preliminary version)",
  "Artist": [
    "Otto Wagner"
  ],
  "ConstituentID": [
    6210
  ],
  "ArtistBio": [
    "Austrian, 1841–1918"
  ],
  "Nationality": [
    "Austrian"
  ],
  "BeginDate": [
    1841
  ],
  "EndDate": [
    1918
  ],
  "Gender": [
    "male"
  ],
  "Date": "1896",
  "Medium": "Ink and cut-and-pasted painted pages on paper",
  "Dimensions": "19 1/8 x 66 1/2\" (48.6 x 168.9 cm)",
  "CreditLine": "Fractional and promised gift of Jo Carole and Ronald S. Lauder",
  "AccessionNumber": "885.1996",
  "Classification": "Architecture",
  "Department": "Architecture & Design",
  "DateAcquired": "1996-04-09",
  "Cataloged": "Y",
  "ObjectID": 2,
  "URL": "https://www.moma.org/collection/works/2",
  "ImageURL": "https://www.moma.org/media/W1siZiIsIjUyNzc3MCJdLFsicCIsImNvbnZlcnQiLCItcmVzaXplIDEwMjR4MTAyNFx1MDAzZSJdXQ.jpg?sha=712ac0fd74ea5bd5",
  "OnView": "",
  "Height (cm)": 48.6,
  "Width (cm)": 168.9
}

It'd be great if all these fields were documented.

In the process, I think it might evoke a conversation about the structure, like why is there a "Gender" field on an artwork? And "BeginDate" and "EndDate" on an artwork sounds like when the artwork was created, not the birth/death dates of the artist. If BeginData were moved to inside the artist then it could also be called birthYear and be an integer rather than an array.

Tiny issues. I know how hard it is to manage the schema for this kind of data, and I appreciate it very much that it is even available as is! Thanks for making it available!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant