Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: mypy is not executed on Python 3.10, 3.11, and 3.12 #270

Closed
Mulugruntz opened this issue Dec 5, 2023 · 0 comments · Fixed by #273
Closed

CI: mypy is not executed on Python 3.10, 3.11, and 3.12 #270

Mulugruntz opened this issue Dec 5, 2023 · 0 comments · Fixed by #273
Assignees

Comments

@Mulugruntz
Copy link
Owner

Mulugruntz commented Dec 5, 2023

The culprit seems to be

    - name: Check with mypy
      if: ${{ !startsWith(matrix.python-version, 'pypy') && matrix.python-version >= '3.7' }}
      run: mypy

The comparison is string to string. Therefore 3.10 < 3.7 (1<7).

The version comparison can be entirely removed, as we don't support < 3.7 anymore.

    - name: Check with mypy
-      if: ${{ !startsWith(matrix.python-version, 'pypy') && matrix.python-version >= '3.7' }}
+      if: ${{ !startsWith(matrix.python-version, 'pypy') }}
      run: mypy
@Mulugruntz Mulugruntz self-assigned this Dec 5, 2023
@Mulugruntz Mulugruntz linked a pull request Dec 5, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant