Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make husky a dev dependency #114

Open
Vinno97 opened this issue Jan 5, 2018 · 1 comment
Open

Make husky a dev dependency #114

Vinno97 opened this issue Jan 5, 2018 · 1 comment

Comments

@Vinno97
Copy link

Vinno97 commented Jan 5, 2018

Hi,

When I install vtop while not being in a root shell, I get the following error:

/usr/local/bin/vtop -> /usr/local/lib/node_modules/vtop/bin/vtop.js

> [email protected] install /usr/local/lib/node_modules/vtop/node_modules/husky
> node ./bin/install.js

husky
setting up hooks in .git/hooks
  fatal: Not a git repository (or any parent up to mount point /)
Stopping at filesystem boundary (GIT_DISCOVERY_ACROSS_FILESYSTEM not set).

While this is most probably caused by how I have installed Node.js, I think that the husky dependency should be moved to the devDependencies. It assume that it is not required to run vtop.

Let me know if my assumptions are correct, I am willing to make the PR.

@MrRio
Copy link
Owner

MrRio commented Jun 26, 2018

I agree this should move to a devDep, sorry for taking so long to comment!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants