Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rarity Colors compatibility #469

Open
ravingdragoon opened this issue Mar 14, 2024 · 0 comments
Open

Rarity Colors compatibility #469

ravingdragoon opened this issue Mar 14, 2024 · 0 comments

Comments

@ravingdragoon
Copy link

Is your feature request related to a problem? Please describe.
When I have Rarity Colors module enabled when munching it lags the import severely and throws an error for almost everything being imported

Describe the solution you'd like
Some sort of compatibility implementation to stop the lag

Describe alternatives you've considered
The only current alternative is to turn off Rarity Colors while doing any munching.

Additional context
Here is the error that it throws for spells being munched when Rarity Colors is enabled:

Uncaught (in promise) TypeError: i[0].querySelector(...) is null
[Detected 3 packages: module-credits, rarity-colors, ddb-importer]
    renderSidebarTab bundle.min.mjs:1
    #call foundry.js:730
    callAll foundry.js:687
    _render foundry.js:5855
    _render foundry.js:69030
    _render foundry.js:70869
    render foundry.js:5769
    <anonymous> raritycolors.js:235
    #call foundry.js:730
    callAll foundry.js:687
    callback foundry.js:13738
    documents foundry.js:13711
    #handleUpdateDocuments foundry.js:13711
    _updateDocuments foundry.js:13458
    update commons.js:8677
    updateDocuments commons.js:8001
    update commons.js:8098
    updateCompendiumItem DDBItemImporter.js:267
    updateCompendiumItems DDBItemImporter.js:300
    updateCompendium DDBItemImporter.js:351
    parseSpells spells.js:141
    parseSpells DDBMuncher.js:282
    activateListeners DDBMuncher.js:89
    jQuery 9
    activateListeners DDBMuncher.js:86
    _render foundry.js:5842
    render foundry.js:5769
    addMuncher addMuncher.js:20
    jQuery 9
    addMuncher addMuncher.js:11
2 [bundle.min.mjs:1:108742](https://assets.forge-vtt.com/bazaar/modules/module-credits/2.2.3/scripts/bundle.min.mjs)
    renderSidebarTab bundle.min.mjs:1
    AsyncFunctionNext self-hosted:852
    (Async: async)
    #call foundry.js:730
    callAll foundry.js:687
    _render foundry.js:5855
    AsyncFunctionNext self-hosted:852
    (Async: async)
    _render foundry.js:69030
    _render foundry.js:70869
    render foundry.js:5769
    <anonymous> raritycolors.js:235
    #call foundry.js:730
    callAll foundry.js:687
    callback foundry.js:13738
    documents foundry.js:13711
    map self-hosted:221
    #handleUpdateDocuments foundry.js:13711
    InterpretGeneratorResume self-hosted:1465
    AsyncFunctionNext self-hosted:852
    (Async: async)
    _updateDocuments foundry.js:13458
    AsyncFunctionNext self-hosted:852
    (Async: async)
    update commons.js:8677
    AsyncFunctionNext self-hosted:852
    (Async: async)
    updateDocuments commons.js:8001
    update commons.js:8098
    updateCompendiumItem DDBItemImporter.js:267
    InterpretGeneratorResume self-hosted:1465
    AsyncFunctionNext self-hosted:852
    (Async: async)
    updateCompendiumItems DDBItemImporter.js:300
    AsyncFunctionNext self-hosted:852
    (Async: async)
    updateCompendium DDBItemImporter.js:351
    AsyncFunctionNext self-hosted:852
    (Async: async)
    parseSpells spells.js:141

Here is the error that it throws for items being munched when Rarity Colors is enabled:

Uncaught (in promise) TypeError: i[0].querySelector(...) is null
[Detected 3 packages: module-credits, rarity-colors, ddb-importer]
    renderSidebarTab bundle.min.mjs:1
    #call foundry.js:730
    callAll foundry.js:687
    _render foundry.js:5855
    _render foundry.js:69030
    _render foundry.js:70869
    render foundry.js:5769
    <anonymous> raritycolors.js:235
    #call foundry.js:730
    callAll foundry.js:687
    callback foundry.js:13738
    documents foundry.js:13711
    #handleUpdateDocuments foundry.js:13711
    _updateDocuments foundry.js:13458
    update commons.js:8677
    updateDocuments commons.js:8001
    update commons.js:8098
    updateCompendiumItem DDBItemImporter.js:267
    updateCompendiumItems DDBItemImporter.js:300
    updateCompendium DDBItemImporter.js:351
    parseItems items.js:220
    parseItems DDBMuncher.js:317
    activateListeners DDBMuncher.js:94
    jQuery 9
        dispatch
        handle
        add
        Ee
        each
        each
        Ee
        on
        n
    activateListeners DDBMuncher.js:91
    _render foundry.js:5842
    render foundry.js:5769
    addMuncher addMuncher.js:20
    jQuery 9
    addMuncher addMuncher.js:11
[bundle.min.mjs:1:108742](https://assets.forge-vtt.com/bazaar/modules/module-credits/2.2.3/scripts/bundle.min.mjs)
    renderSidebarTab bundle.min.mjs:1
    AsyncFunctionNext self-hosted:852
    (Async: async)
    #call foundry.js:730
    callAll foundry.js:687
    _render foundry.js:5855
    AsyncFunctionNext self-hosted:852
    (Async: async)
    _render foundry.js:69030
    _render foundry.js:70869
    render foundry.js:5769
    <anonymous> raritycolors.js:235
    #call foundry.js:730
    callAll foundry.js:687
    callback foundry.js:13738
    documents foundry.js:13711
    map self-hosted:221
    #handleUpdateDocuments foundry.js:13711
    AsyncFunctionNext self-hosted:852
    (Async: async)
    _updateDocuments foundry.js:13458
    AsyncFunctionNext self-hosted:852
    (Async: async)
    update commons.js:8677
    AsyncFunctionNext self-hosted:852
    (Async: async)
    updateDocuments commons.js:8001
    update commons.js:8098
    updateCompendiumItem DDBItemImporter.js:267
    AsyncFunctionNext self-hosted:852
    (Async: async)
    updateCompendiumItems DDBItemImporter.js:300
    AsyncFunctionNext self-hosted:852
    (Async: async)
    updateCompendium DDBItemImporter.js:351
    AsyncFunctionNext self-hosted:852
    (Async: async)
    parseItems items.js:220
    InterpretGeneratorResume self-hosted:1465
    AsyncFunctionNext self-hosted:852
    (Async: async)
    parseItems DDBMuncher.js:317
    InterpretGeneratorResume self-hosted:1465
    AsyncFunctionNext self-hosted:852
    (Async: async)
    activateListeners DDBMuncher.js:94
    jQuery 9
    activateListeners DDBMuncher.js:91
    _render foundry.js:5842
    AsyncFunctionNext self-hosted:852
    (Async: async)
    render foundry.js:5769
    addMuncher addMuncher.js:20
    InterpretGeneratorResume self-hosted:1465
    AsyncFunctionNext self-hosted:852
    jQuery 9
    addMuncher addMuncher.js:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant