Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Any plans for manual classification of red cells through the GUI? #528

Closed
nmlynaryk opened this issue Aug 28, 2020 · 5 comments
Closed

Any plans for manual classification of red cells through the GUI? #528

nmlynaryk opened this issue Aug 28, 2020 · 5 comments
Assignees
Labels
enhancement New feature or request

Comments

@nmlynaryk
Copy link

I see that we can currently view the "mean img chan2" and the "mean img chan2, corr" (this looks like max projection?), and you can change the threshold for calling a cell RED with the number next to the chan2 prob button (though this doesn't produce major changes to my data so far), but I'm wondering if there are any plans to be able to edit the redcell.npy file directly through the GUI, in the same way we edit the iscell.npy by moving cells to the left or right panel? A separate set of panels to manually classify detected ROIs as red or not could be very useful.

@marius10p marius10p added the enhancement New feature or request label Sep 4, 2020
@marius10p
Copy link
Contributor

This was a feature in the Matlab version that we should be able to bring back, but it'll probably have to wait a bit.

@Diegoalvarezar
Copy link

Just a remainder that this would be very useful!
Thanks!
Diego

@marius10p
Copy link
Contributor

Could you please try to implement it yourself and contribute it back to Suite2p as a pull request?

@marysethomas
Copy link

@marius10p This feature would also be very helpful for our group. At the Suite2p summer workshop in 2019, you helped one of our lab members add a keyboard shortcut that could change a cell from "red cell" to "not red cell". I attempted to integrate this into the current Suite2p code, but things have changed quite a bit and I am not a Python user, so I was unable to do so.

Here is the script where I found the shortcut, but it might also be referenced in other places that I didn't see:
gui2p.zip

Sharing this in the hopes that it can help you or another user attempt to re-include this feature!

@marysethomas
Copy link

marysethomas commented Dec 10, 2021

Made a pull request here #785 and here #786

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

5 participants