Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Range order #285

Closed
wants to merge 9 commits into from
Closed

Range order #285

wants to merge 9 commits into from

Conversation

arkanoider
Copy link
Collaborator

Hi @grunch ,

some steps ahead also on mostro side, what's implemented now ( to be deeply tested anyway ):

  • Updated cargo.toml for mostro-core 5.10
  • Removed not null conditions from db file to avoid errors on db entry creation due to max_amount and min_amount null possible value
  • If order is with range now we check if sats amount conversion is inside limit for both values, if order is no range order same logic as before
  • Implemented same logic of lnP2P bot to diminish max amount or ranged order and mark it as successful ( this part need to be fully tested and improved in style )

Missing things in my mind:

  • TakeBuy and TakeSell checks if amount received is in the range of order and in case send back a message to user.
  • Testing everything

@grunch
Copy link
Member

grunch commented May 17, 2024

I could create a new range order, how can I take it? for this you should write new specs for different situation, here an example:

https://mostro.network/messages/take_sell.html

@arkanoider
Copy link
Collaborator Author

I could create a new range order, how can I take it? for this you should write new specs for different situation, here an example:

https://mostro.network/messages/take_sell.html

Yep! We will have to update specs with new range order case, let's complete the code to have a workin version and then I will write specs

@arkanoider
Copy link
Collaborator Author

Added logic to check if fiat amount value sent from CLI is in range.
This won't passe CI test because of mostro-core new version

@grunch
Copy link
Member

grunch commented May 21, 2024

closing it in favor of #286

@grunch grunch closed this May 21, 2024
@arkanoider arkanoider deleted the range-order branch May 21, 2024 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants