Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Latest nostr sdk #103

Merged
merged 5 commits into from
Aug 19, 2023
Merged

Latest nostr sdk #103

merged 5 commits into from
Aug 19, 2023

Conversation

arkanoider
Copy link
Collaborator

Updated project to compile with latest nostr-sdk 0.22.

Some modifications introduced to some data for compatibility, completely to be tested.

Improved some management of config file dir command. Could be workin on windows too now, also if Os folder management it's a bit tricky. To be tested.

@grunch
Copy link
Member

grunch commented Aug 18, 2023

Hey buddy, tests are failing, can you fix them before merging it?

@arkanoider
Copy link
Collaborator Author

Fixed!

Give a look if you like it...
I changed settings.toml to settings.tpl.toml to have a template for doc to load on testing.
Issue is coming from expired invoice, but then with new settings we had an issue due to 0 as min amount.
I did this to fix...
Let me know @grunch !

Copy link
Member

@grunch grunch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! thanks buddy, let's keep testing and improving this 😃

@grunch grunch merged commit 2017834 into MostroP2P:main Aug 19, 2023
1 check passed
@arkanoider arkanoider deleted the latest-nostr-sdk branch August 19, 2023 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants