Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New nip33 event to publish mostro useful data #257

Closed
grunch opened this issue Apr 15, 2024 · 6 comments
Closed

New nip33 event to publish mostro useful data #257

grunch opened this issue Apr 15, 2024 · 6 comments
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@grunch
Copy link
Member

grunch commented Apr 15, 2024

We need to publish a scheduled event that gives useful Mostro's information to users, I'm thinking something like this:

[
  "EVENT",
  "RAND",
  {
    "id": "84fad0d29cb3529d789faeff2033e88fe157a48e071c6a5d1619928289420e31",
    "pubkey": "dbe0b1be7aafd3cfba92d7463edbd4e33b2969f61bd554d37ac56f032e13355a",
    "created_at": 1702548701,
    "kind": 38383,
    "tags": [
      ["d", "dbe0b1be7aafd3cfba92d7463edbd4e33b2969f61bd554d37ac56f032e13355a"],
      ["mostro_fee", "0.006"],
      ["max_routing_fee", "0.002"],
      ["max_order_amount", "1000000"],
      ["expiration_hours", "24"],
      ["max_expiration_days", "15"],
      ["relays", [
         "ws://localhost:7000",
         "ws://localhost:8000",
      ]],
      ["version", "0.11.5"],
      ["commit", "09e9862a7f572f73483935166d515d84863b84d6"],
      ["ln_node", "031df9367377758ef6a167f218023c5a1dcf3994d3e96327d32f0f008548fe4236@g4zneovmezzbtsrqux3ayfafllmj3qc5cdhm6nvxkyqhk7cevk2ofpid.onion:9735"]
      ["y", "mostrop2p"],
      ["z", "settings"]
    ],
    "content": "",
    "sig": "7e8fe1eb644f33ff51d8805c02a0e1a6d034e6234eac50ef7a7e0dac68a0414f7910366204fa8217086f90eddaa37ded71e61f736d1838e37c0b73f6a16c4af2"
  }
]
@grunch grunch added enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed labels Apr 15, 2024
@tincho70
Copy link
Contributor

First at all, I've a question: why tags and not content?
Then, maybe add additional information with statistics about trades (number of succefull last 1, 15 and 30 days)

@Catrya
Copy link
Collaborator

Catrya commented Apr 15, 2024

I also think it's good to add: mostro's uptime, the average time in which the solvers take the disputes, Mostro rate (when implemented)

@grunch
Copy link
Member Author

grunch commented Apr 16, 2024

First at all, I've a question: why tags and not content? Then, maybe add additional information with statistics about trades (number of succefull last 1, 15 and 30 days)

tags are easy to read, they can be extracted from the event easier because there is a nip about tags.

we are trying to implement the stats on this PR #251 but it's not ready yet, I just created an issue here #265 to try to organize better our ideas, please go there for stats related suggestions

@bilthon
Copy link
Contributor

bilthon commented Apr 25, 2024

The expiration_seconds is another configuration parameter that would be nice to include here. Right now the web client has this visual countdown, but it's value is hard-coded to 15 minutes. It would be nice to be able to extract this data from the NIP-33 event.

Also regarding the relay list, I think NIP-65 specifies kind 10002 precisely for this purpose. So it might be better to put relay data there.

@arkanoider
Copy link
Collaborator

A first implementation of mostro settings is presented in #279 .

Waiting for review.

@grunch
Copy link
Member Author

grunch commented May 6, 2024

closing it via #279

@grunch grunch closed this as completed May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

5 participants