implement try_on_runtime_upgrade

[girazoki]

Implements try_on_runtime_upgrade in pallet migrations. Otherwise after the 1.3.0 upgrade we see the error:

panicked at 'called Result::unwrap()on anErrvalue: Other("Usage ofpre_upgradewith Tuples is not expected. Please usetry_on_runtime_upgradeinstead, which internally callspre_upgrade->on_runtime_upgrade->post_upgrade for each tuple member.")

[rimbi]

The version in the branch moonbeam-polkadot-v1.1.0 is shorter. You should take a look.

[girazoki]

what?

[rimbi]

impl<T> OnRuntimeUpgrade for ExecutiveHooks<T>
where
	T: Config,
{
	fn on_runtime_upgrade() -> Weight {
		if Pallet::<T>::maintenance_mode() {
			T::MaintenanceExecutiveHooks::on_runtime_upgrade()
		} else {
			T::NormalExecutiveHooks::on_runtime_upgrade()
		}
	}

	#[cfg(feature = "try-runtime")]
	fn try_on_runtime_upgrade(checks: bool) -> Result<Weight, TryRuntimeError> {
		if Pallet::<T>::maintenance_mode() {
			T::MaintenanceExecutiveHooks::try_on_runtime_upgrade(checks)
		} else {
			T::NormalExecutiveHooks::try_on_runtime_upgrade(checks)
		}
	}
}

[girazoki]

Oh I see yes we dont need the pre and post hooks now. Why isnt this merged into master if it is in moonbeam-polkadot-v1.1.0?

[rimbi]

Because I have not been aware of this convention (merging each change to master as well). But we had a conversation about this change before.

[girazoki]

In general any change that is not moonbeam specific it should be merged to master