Skip to content

Commit

Permalink
Settings upgrades for increasing the maximum Soroban key size to 250 …
Browse files Browse the repository at this point in the history
…bytes (stellar#4371)

# Description

Settings upgrades for increasing the maximum Soroban key size to 250
bytes.

200 bytes ended up being too conservative and it's not sufficient to
support the built-in Stellar Asset contract allowance (that might need
up to 204 bytes/key).

# Checklist
- [ ] Reviewed the
[contributing](https://github.com/stellar/stellar-core/blob/master/CONTRIBUTING.md#submitting-changes)
document
- [ ] Rebased on top of master (no merge commits)
- [ ] Ran `clang-format` v8.0.0 (via `make format` or the Visual Studio
extension)
- [ ] Compiles
- [ ] Ran all tests
- [ ] If change impacts performance, include supporting evidence per the
[performance
document](https://github.com/stellar/stellar-core/blob/master/performance-eval/performance-eval.md)
  • Loading branch information
sisuresh authored Jun 28, 2024
2 parents 1df43a9 + b041cb7 commit 68f43a5
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 1 deletion.
7 changes: 7 additions & 0 deletions soroban-settings/pubnet_phase4.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"updated_entry": [
{
"contract_data_key_size_bytes": 250
}
]
}
2 changes: 1 addition & 1 deletion soroban-settings/testnet_settings.json
Original file line number Diff line number Diff line change
Expand Up @@ -507,7 +507,7 @@
]
},
{
"contract_data_key_size_bytes": 200
"contract_data_key_size_bytes": 250
},
{
"contract_data_entry_size_bytes": 65536
Expand Down

0 comments on commit 68f43a5

Please sign in to comment.