Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

why line coverage is displayed as a badge? #90

Open
aviralpostman opened this issue Jun 6, 2024 · 3 comments
Open

why line coverage is displayed as a badge? #90

aviralpostman opened this issue Jun 6, 2024 · 3 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@aviralpostman
Copy link

Is there any particular reason to show only line coverage as a badge?
Also, in this PR for relative coverage, why are we displaying the change in line coverage only and why not for others?

@MishaKav
Copy link
Owner

MishaKav commented Jun 6, 2024

There are now particular reason, just because devs love badges :)
If more people will vote for this, I think It could be an option to enrich the config.

@MishaKav MishaKav added the good first issue Good for newcomers label Jun 6, 2024
@aviralpostman
Copy link
Author

ah, ok. I got confused there. Googled if line coverage is superior to others 😭.

Anyways, I've a feature request too: Can we have a flag to compare the coverage change wrt to the main branch?
This would require to clone the main branch => run tests there => use the PR linked in the description to show the coverage difference.
Lmk if this feature is already in works.

@MishaKav
Copy link
Owner

MishaKav commented Jun 9, 2024

Relative coverage has been requested several times, currently, I don't have enough time to develop this by myself, but there is initiated PR #40, so someone will, based on this, suggest a PR for this feature.

@MishaKav MishaKav added the enhancement New feature or request label Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants