Cleanup component dependencies when removed #584
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zerospiel
force-pushed
the
comp_cleanup
branch
4 times, most recently
from
f46f509 to
85c019d
Compare
Kshatrix
requested changes
Nov 1, 2024
zerospiel
force-pushed
the
comp_cleanup
branch
from
85c019d to
16df855
Compare
zerospiel
force-pushed
the
comp_cleanup
branch
4 times, most recently
from
ed67f91 to
3ded089
Compare
Kshatrix
requested changes
Nov 7, 2024
* if component is removed from management object the related helmreleases, providertemplates and helmcharts are deleted now * small code amends * test coverage for the mgmt-ctrl raised from 4.4% to 45.6% Closes k0rdent#553
zerospiel
force-pushed
the
comp_cleanup
branch
from
3ded089 to
3b77e9c
Compare
Kshatrix
approved these changes
Nov 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #553