Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create release in hmc-templates by default #533

Merged
merged 2 commits into from
Oct 18, 2024
Merged

Create release in hmc-templates by default #533

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
800c135
Fix initial release creation
Kshatrix Oct 18, 2024
fd016ec
Fix version trimming in Makefile
Kshatrix Oct 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
NAMESPACE ?= hmc-system
VERSION ?= $(patsubst v%,%,$(shell git describe --tags --always))
VERSION ?= $(shell git describe --tags --always)
VERSION := $(patsubst v%,%,$(VERSION))
FQDN_VERSION = $(subst .,-,$(VERSION))
# Image URL to use all building/pushing image targets
IMG ?= hmc/controller:latest
Expand Down
3 changes: 2 additions & 1 deletion internal/controller/release_controller.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -192,6 +192,7 @@ func (r *ReleaseReconciler) reconcileHMCTemplates(ctx context.Context, releaseNa
l.Info("Initial creation of HMC Release is skipped")
return nil
}
initialInstall := releaseName == ""
var ownerRefs []metav1.OwnerReference
if releaseName == "" {
releaseName = utils.ReleaseNameFromVersion(build.Version)
Expand Down Expand Up @@ -252,7 +253,7 @@ func (r *ReleaseReconciler) reconcileHMCTemplates(ctx context.Context, releaseNa
},
}

if releaseName == "" {
if initialInstall {
createReleaseValues := map[string]any{
"createRelease": true,
}
Expand Down
Loading