generated from MinBZK/python-project-template
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
361 taskmeasureinstrument handling with document upload and status change #410
Merged
laurensWe
merged 3 commits into
main
from
361-taskmeasureinstrument-handling-with-document-upload-and-status-change
Dec 17, 2024
Merged
361 taskmeasureinstrument handling with document upload and status change #410
laurensWe
merged 3 commits into
main
from
361-taskmeasureinstrument-handling-with-document-upload-and-status-change
Dec 17, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 tasks
ChristopherSpelt
force-pushed
the
361-taskmeasureinstrument-handling-with-document-upload-and-status-change
branch
5 times, most recently
from
December 10, 2024 10:13
4fa03e5
to
41aa229
Compare
ChristopherSpelt
force-pushed
the
361-taskmeasureinstrument-handling-with-document-upload-and-status-change
branch
7 times, most recently
from
December 11, 2024 15:24
af1f9bb
to
d932fa6
Compare
laurensWe
force-pushed
the
361-taskmeasureinstrument-handling-with-document-upload-and-status-change
branch
from
December 13, 2024 10:48
d932fa6
to
a759af3
Compare
laurensWe
previously approved these changes
Dec 13, 2024
laurensWe
force-pushed
the
361-taskmeasureinstrument-handling-with-document-upload-and-status-change
branch
3 times, most recently
from
December 17, 2024 14:56
9708298
to
434fa23
Compare
laurensWe
force-pushed
the
361-taskmeasureinstrument-handling-with-document-upload-and-status-change
branch
from
December 17, 2024 15:25
434fa23
to
b9d2d42
Compare
ravimeijerrig
previously approved these changes
Dec 17, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM :)
ravimeijerrig
approved these changes
Dec 17, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM :)
Quality Gate failedFailed conditions |
laurensWe
deleted the
361-taskmeasureinstrument-handling-with-document-upload-and-status-change
branch
December 17, 2024 15:50
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What is added
(todo, in progress, in review, done, not implemented)
. Note that this also means adding additional colours to the status bar icon in the measures in the requirements overview. Since the status bar only has a limited set of colours, this is now suboptimal visually. The current colours are aligned with Ruben.links
.What is not added
What still needs to be done
Estimation of leftover points: 1 or 2.
If things don't work properly
-> Berry probably knows most about the Minio side of things
-> Robbert U knows probably most about the way the UI of the form is implemented
How to tests things locally
Use a local instance of Minio with the settings which are specified in the core settings in AMT.
Resolves #361
Checklist
Please check all the boxes that apply to this pull request using "x":