Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add end-indicator decision tree and change session settings #226

Closed
robbertbos opened this issue Oct 28, 2024 · 1 comment · Fixed by #248
Closed

Add end-indicator decision tree and change session settings #226

robbertbos opened this issue Oct 28, 2024 · 1 comment · Fixed by #248
Assignees

Comments

@robbertbos
Copy link
Member

robbertbos commented Oct 28, 2024

Description

  1. The current decision tree does not contain a button indicating that the end has been reached and the results can be saved.
    Part of the work is agreeing how exactly this should be reflected in the decision tree.

  2. It is also necessary to revise the storage structure. Currently, the browser remembers history, so that when the decision tree is reopened, previously entered information is still visible. The proposal is to remember data by ‘session’ rather than by browser.

Sketch of the design:
Image

Implementation Notes

  • Set local storage to remember data by ‘session’ rather than by browser
  • Add 'Sluit' button to conclusion page. The Sluit button closes the decision tree modal/page. Saving the results is out of scope for now.
  • Also change AMT to use the sessionstorage for the retrieval of the labels compared to localstorage right now
@robbertbos robbertbos converted this from a draft issue Oct 28, 2024
@ravimeijerrig ravimeijerrig changed the title Add end-indicator decision tree Add end-indicator decision tree and change session settings Oct 30, 2024
@laurensWe laurensWe self-assigned this Nov 12, 2024
@laurensWe
Copy link
Member

Waiting for feedback from heitske

@laurensWe laurensWe linked a pull request Nov 13, 2024 that will close this issue
@github-project-automation github-project-automation bot moved this from ⛔ Blocked / Waiting to ✅ Done in 👾 AI Validation Team Planning Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging a pull request may close this issue.

2 participants