Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a stress test for concurrently visiting the AST #952

Open
MikePopoloski opened this issue Apr 7, 2024 · 0 comments
Open

Add a stress test for concurrently visiting the AST #952

MikePopoloski opened this issue Apr 7, 2024 · 0 comments

Comments

@MikePopoloski
Copy link
Owner

AST construction is not thread safe, and the first full visitation / elaboration is not either (since AST nodes are constructed lazily). Once the full AST has been visited and every single node touched, it should be safe to visit the AST again concurrently since it should be effectively immutable thereafter.

Add a test that visits a large AST via multiple threads multiple times over and tries to weed out any cases where we are not actually immutable after construction. ThreadSanitizer may be helpful here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant