Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add caching of identical instance bodies #949

Open
MikePopoloski opened this issue Apr 7, 2024 · 2 comments
Open

Add caching of identical instance bodies #949

MikePopoloski opened this issue Apr 7, 2024 · 2 comments

Comments

@MikePopoloski
Copy link
Owner

Support caching instance bodies and skipping over identical copies when elaborating, to save time. Expose this functionality so that downstream consumers of the AST can easily do the same.

Note that the tricky detail here is figuring out how to handle hierarchical references into and out of the cached instances.

@yanggeorge
Copy link

yanggeorge commented Apr 29, 2024

It is better that elabarated AST only keeps one instance of those identical instances, then visiting the AST will be faster.

@likeamahoney
Copy link
Contributor

My hash suggestion - #1088 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants