Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reorganize parameters classes #58

Open
MikeHeiber opened this issue Jan 10, 2019 · 1 comment
Open

Reorganize parameters classes #58

MikeHeiber opened this issue Jan 10, 2019 · 1 comment
Labels
enhancement Primarily code enhancements or other minor improvements that do not affect the main functionality.

Comments

@MikeHeiber
Copy link
Owner

Parameters_Simulation and Parameters_Lattice could be reorganized a separate Parameters classes nested within the Simulation and Lattice classes respectively. Also, since the Simulation class contains a Lattice member variable, Simulation::Parameters could inherit from Lattice::Parameters to create a single derived class with all of the required parameters.
@MikeHeiber MikeHeiber added the enhancement Primarily code enhancements or other minor improvements that do not affect the main functionality. label Jan 10, 2019
@MikeHeiber
Copy link
Owner Author

This will break the current API and must wait until v3.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement Primarily code enhancements or other minor improvements that do not affect the main functionality.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@MikeHeiber