Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove from "test_shock.py" redundant test functions for "magnitude" vs. "phase" #181

Open
CrepeGoat opened this issue Feb 16, 2022 · 0 comments
Labels
endaq.calc Related to `endaq.calc` enhancement New feature or request

Comments

@CrepeGoat
Copy link
Contributor

The tests in "test_shock.py" confirm the correctness of the shock spectra functions by validating the impulse responses for each function. Validation is currently performed by first confirming the impulse response's magnitude, which is generated by one set of functions, and then separately confirming the impulse response's phase, which is generated by a different set of functions.

This could be consolidated by combining the magnitude code and phase code for generation/validation, which would cut the number of test functions in half, w/o affecting the breadth of features being tested or increasing code complexity. The reduction in code size should make the tests easier to maintain.

@CrepeGoat CrepeGoat added the endaq.calc Related to `endaq.calc` label Feb 16, 2022
@StokesMIDE StokesMIDE added the enhancement New feature or request label May 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
endaq.calc Related to `endaq.calc` enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants