Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add .horoscope command #23

Closed
satyamrs00 opened this issue Oct 9, 2022 · 5 comments · Fixed by #34
Closed

Add .horoscope command #23

satyamrs00 opened this issue Oct 9, 2022 · 5 comments · Fixed by #34
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers hacktoberfest HacktoberFest Issues

Comments

@satyamrs00
Copy link
Contributor

.horoscope

Public API Resource

https://aztro.readthedocs.io/en/latest/

Description

The API retrieves daily horoscopes for yesterday, today, and tomorrow. It requires name of sign like aries, taurus, gemini, cancer, leo, virgo, libra, scorpio, sagittarius, capricorn, aquarius and pisces.

@Aryan-401 Aryan-401 added enhancement New feature or request good first issue Good for newcomers hacktoberfest HacktoberFest Issues labels Oct 10, 2022
@Aryan-401
Copy link
Member

Aryan-401 commented Oct 10, 2022

@satyamrs00 do you want to work on the command? One idea I had was using the User.created_at function to find a user's "Discord" Horoscope.

https://discordpy.readthedocs.io/en/latest/api.html#discord.User.created_at

Feel free to ideate and create your own command

@satyamrs00
Copy link
Contributor Author

yes I would like to work on this
and I liked the idea of "discord horoscope"
then we need to change the command name to something like ".d-horoscope" or ".doroscope" because ".horoscope" would be misleading

tell me what name it should have , then I will start

@Aryan-401
Copy link
Member

I think horoscope should be fine. Just make sure to clarify in the help parameter. Also make sure to add this to cogs/fun.py.

@satyamrs00
Copy link
Contributor Author

image
image

is this alright ?

@Aryan-401
Copy link
Member

Yup it looks alright, one change would be to change the embed color to blurple

@Aryan-401 Aryan-401 linked a pull request Oct 11, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers hacktoberfest HacktoberFest Issues
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants