Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question about LPIPS and SSIM #8

Open
theodoruszq opened this issue Dec 2, 2022 · 1 comment
Open

Question about LPIPS and SSIM #8

theodoruszq opened this issue Dec 2, 2022 · 1 comment

Comments

@theodoruszq
Copy link

theodoruszq commented Dec 2, 2022

For LPIPS

When evaluating LPIPS metric, the model inference result will be different for each instance for there existing random init weights.

I don't know it is the precision problem or not, keep the input same and torch.load the same weight again and run inference, the result value is different.

Here is my screencaption of two different instances
image

The two values should be the same, but they are not. After set manual seed to 0, they are amost identical.

image

For SSIM

the code ssim_all[v] += ssim(cur_gt_frame, cur_comp_frame, multichannel=True) may be better to change as ssim_all[v] += ssim(cur_gt_frame, cur_comp_frame, multichannel=True, data_range=1), because in the skimage library, it considers np.float32 as (-1, 1) range, but actually it is (0, 1) in our situation.

Of course, the minor problems do not affect the conclusions in the paper~

Thank you~

@theodoruszq theodoruszq changed the title Question about LPIPS Question about LPIPS and SSIM Dec 2, 2022
@rszeto
Copy link
Collaborator

rszeto commented Jul 1, 2023

Hi @sydney0zq,

Sorry about the terribly late response. The LPIPS issue has been fixed in commit de25552. I will try to investigate the SSIM part as well, though it might lie outside the scope of maintenance if it does not affect results.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants