Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Smoke tests should use linkcheck config from book.toml #47

Open
wonderfulspam opened this issue Oct 26, 2020 · 0 comments
Open

Smoke tests should use linkcheck config from book.toml #47

wonderfulspam opened this issue Oct 26, 2020 · 0 comments

Comments

@wonderfulspam
Copy link
Contributor

wonderfulspam commented Oct 26, 2020

While expanding the test suite for #46, it occurred to me that the smoke tests should use the linkcheck config specified in the book.toml (example). Currently, the configuration is hardcoded for all tests and the linkcheck part of book.toml exists for cosmetic reasons only as far as I can tell.

I'm happy to submit a PR to fix this but wanted to get your thoughts first. My initial thought was to deserialize a mdbook-linkcheck Config struct from the relevant part of the book.toml but it seems like this could be fixed simply by not overriding the linkcheck config?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant