Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Advanced error handling #35

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Advanced error handling #35

wants to merge 3 commits into from

Conversation

Michael-F-Bryan
Copy link
Owner

(fixes #12)

@pihme pihme mentioned this pull request Jun 25, 2020
Closed
Veetaha
Veetaha reviewed Aug 25, 2020
View reviewed changes
Cargo.toml
@@ -32,6 +32,7 @@ serde_derive = "1.0"
serde_json = "1.0"
structopt = "0.3"
tokio = "0.2.20"
lazy_static = "1.4.0"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would recommend using once_cell crate, because it is going to be a standard way to handle lazy initialization of static variables. By "standard" I mean literally standard, this crate is already exposed as part of std, though unstable: rust-lang/rust#74465

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Veetaha Veetaha Veetaha left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Configurable HTTP Error Handling
2 participants
@Michael-F-Bryan @Veetaha