Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DietPi-Software | Docker Compose: Switch from standalone binary to APT package #6135

Closed
isarrider opened this issue Feb 7, 2023 · 10 comments
Milestone

Comments

@isarrider
Copy link

Hi,

I just noticed that buildx is (not anymore?) installed,
when docker is installed...
Is this intentional?

(easy fix to install the plugins:
sudo apt-get install docker-buildx-plugin docker-compose-plugin)

BR;
Alex

@Joulinar
Copy link
Collaborator

Joulinar commented Feb 7, 2023

from our side we don't change / touch anything. Our install script is going to install docker-ce package (only). This is the case for long. Probably things changed on lates Docker release v23 https://docs.docker.com/engine/release-notes/23.0/#new

@MichaIng
Copy link
Owner

MichaIng commented Feb 7, 2023

docker-compose-plugin

This is deprecated: https://docs.docker.com/compose/install/linux/
Use the Docker Compose install option from DietPi-Software, or install the new binary manually.

EDIT: Ah sorry, I'm wrong. The package does ship the new V2, all good. Actually we can use that package as well then instead of manually downloading the binary. Not sure when that changed 🙂.

@MichaIng MichaIng added this to the v8.14 milestone Feb 7, 2023
@isarrider
Copy link
Author

actually it make sense that it doesnt come with docker by defautl... (keepin it lean)
Only on build system it is needed... Maybe another install option?

@MichaIng
Copy link
Owner

MichaIng commented Feb 7, 2023

As long as it is not more than apt install, we usually do not implement install options, at least not if those are not a dependency of other implemented install options. But we could add a hint to our docs about other Docker packages available from the Docke repo.

@MichaIng MichaIng changed the title Docker - buildx DietPi-Software | Docker Compose: Switch from standalone binary to APT package Feb 9, 2023
MichaIng added a commit that referenced this issue Feb 10, 2023
- DietPi-Software | Docker Compose: Migrated to the plugin variant, installed from the Docker APT repository. On existing installs, the migration can be done via "dietpi-software reinstall 134". To call it, use "docker compose" (without dash) from now on. Many thanks to @isarrider for making us aware of this: #6135
@MichaIng MichaIng added the Solution available 🥂 Definite solution has been done label Feb 10, 2023
@MichaIng
Copy link
Owner

Done with: f95bd3a

@MichaIng MichaIng mentioned this issue Feb 10, 2023
@isarrider
Copy link
Author

I feel my thread was hijacked 😉
For me it was about buildx...
But happy for the folks who have the Go version of compose now 😉

@Joulinar
Copy link
Collaborator

We ship the Go version vor long time already.

@MichaIng
Copy link
Owner

I feel my thread was hijacked 😉

Yeah, you are right, especially since with #6142 an explicit request to use the Docker Compose APT package was opened, though including the same misunderstanding that this would be Python/v1 to Go/v2 switch, which it is not, but which was done with DietPi v8.2 already. However, I didn't know about the APT package until you posted it here 😄.

@isarrider
Copy link
Author

well - then I am glad...
So means leaving docker buildx as it is now
(fine w me,
maybe a short line in the docu would be good?)

@MichaIng
Copy link
Owner

I think it was installed together with Docker previously either, same as Docker Compose. And it is good like that, as it is not needed by most users. Good idea to add some hint to the docs about plugins/packages available from the Docker APT repo: MichaIng/DietPi-Docs#850

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants