Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DietPi-Software | Node.js: taaem installer now completely broken #3650

Closed
MichaIng opened this issue Jul 5, 2020 · 4 comments · Fixed by #3651
Closed

DietPi-Software | Node.js: taaem installer now completely broken #3650

MichaIng opened this issue Jul 5, 2020 · 4 comments · Fixed by #3651
Labels
External bug 🐞 For bugs which are not caused by DietPi. Workaround available 🆗 Workaround is available/has been implemented, but a definite solution should be found when possible.
Milestone
v6.32

Comments

@MichaIng
Copy link
Owner

MichaIng commented Jul 5, 2020

https://github.com/taaem/nodejs-linux-installer/blob/master/node-install.sh#L13

This curl check is now doomed to fail since nodejs.org has HTTPS redirect enabled (now) which makes curl output being empty without -L option.

My PR fixes this by using HTTPS, however the -L open additionally makes sense as file structure might change.

For now I'll switch to my fork, probably integrate this completely into dietpi-software, if taaem does not maintain it anymore.
@MichaIng MichaIng added the External bug 🐞 For bugs which are not caused by DietPi. label Jul 5, 2020
@MichaIng MichaIng added this to the v6.32 milestone Jul 5, 2020
@MichaIng MichaIng linked a pull request Jul 5, 2020 that will close this issue
DietPi-Software | Node.js: Use fixed own installer fork #3651
Merged
2 tasks
@MichaIng MichaIng added Solution available 🥂 Definite solution has been done Testing/testers required 🔽 Workaround available 🆗 Workaround is available/has been implemented, but a definite solution should be found when possible. and removed Solution available 🥂 Definite solution has been done labels Jul 5, 2020
@MichaIng
Copy link
Owner Author

MichaIng commented Jul 5, 2020 •
edited
Loading

MOTD live patch is up:

[[ -w '/boot/dietpi/dietpi-software' ]] && grep -q taaem /boot/dietpi/dietpi-software && sed -i 's/taaem/MichaIng/' /boot/dietpi/dietpi-software

@marius86ar
Copy link

not working

@MichaIng
Copy link
Owner Author

MichaIng commented Jul 5, 2020 •
edited
Loading

Bug in my MOTD hack, please fix with:

rm /run/dietpi/.dietpi-motd
curl -sSfL https://raw.githubusercontent.com/MichaIng/DietPi/master/dietpi/dietpi-software > /boot/dietpi/dietpi-software
sed -i 's/taaem/MichaIng/' /boot/dietpi/dietpi-software

@MichaIng MichaIng changed the title DietPi-Software | Node.js: teeam installer now completely broken DietPi-Software | Node.js: taaem installer now completely broken Jul 6, 2020
@MichaIng
Copy link
Owner Author

MichaIng commented Jul 9, 2020

I'll mark this as closed. Own script works fine, I'll give taaem some time to react before merging code into dietpi-software.

@MichaIng MichaIng closed this as completed Jul 9, 2020
@Joulinar Joulinar mentioned this issue Jul 14, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
External bug 🐞 For bugs which are not caused by DietPi. Workaround available 🆗 Workaround is available/has been implemented, but a definite solution should be found when possible.
Projects
None yet
Milestone
v6.32
Development

Successfully merging a pull request may close this issue.

DietPi-Software | Node.js: Use fixed own installer fork MichaIng/DietPi
2 participants
@marius86ar @MichaIng